Stripe initial impl#27
Merged
davidcheung merged 6 commits intomainfrom May 17, 2021
Merged
Conversation
davidcheung
force-pushed
the
stripe-initial-impl
branch
2 times, most recently
from
522aa98 to
0b5abde
Compare
davidcheung
force-pushed
the
stripe-initial-impl
branch
from
0b5abde to
b2713dc
Compare
bmonkman
reviewed
Apr 27, 2021
bmonkman
reviewed
Apr 27, 2021
bmonkman
reviewed
Apr 27, 2021
bmonkman
reviewed
Apr 27, 2021
bmonkman
reviewed
Apr 27, 2021
bmonkman
reviewed
Apr 27, 2021
bmonkman
reviewed
Apr 27, 2021
| res.redirect(`${FRONTEND_URL}/billing/confirmation?&${mapToQueryString(data)}`) | ||
| }); | ||
|
|
||
| router.use("/webhook*", async (req, res) => { |
Contributor
There was a problem hiding this comment.
How about we use the proper /webhook/stripe path to be clear and to make it more obvious that there could be other webhooks here.
Contributor
Author
There was a problem hiding this comment.
oh sorry I actually moved this to
just <api>/webhook/ in the public and forgot to remove this one
because of the way oathkeeper is setup its hard to route anything unauthenticated request into <api>/billing
bmonkman
reviewed
Apr 27, 2021
| "no": "No" | ||
| - field: stagingStripePublicApiKey | ||
| label: "Staging Stripe public api key, used for frontend repository (Recommended: using sandbox key while setting up)" | ||
| conditions: |
Contributor
There was a problem hiding this comment.
So nice that we can have these conditionals now! 😂
bmonkman
reviewed
Apr 27, 2021
| }); | ||
| <% if eq (index .Params `billingEnabled`) "yes" %> | ||
| // Logging out webhooks for development purposes | ||
| router.use("/webhook", (req, res) => { |
Contributor
There was a problem hiding this comment.
Can you change this to handle /webhook/stripe to be more explicit?
bmonkman
approved these changes
Apr 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.